admin/quick-n-dirty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix "scandir should not need to sort in b.php (banner code)"

Browse Source 
scandir by default sorts files in ascending order. this is unnecessary when you're picking a random file anyway. it's just wasting CPU cycles and increasing latency as more files are added.

currently it is

    $files = scandir($dir);

it should be

    $files = scandir($dir, SCANDIR_SORT_NONE);
This commit is contained in:
Majin Bejitto
2022-12-21 03:25:49 -05:00
committed by Fredrick Brennan
parent a0f699d49f
commit 23163ae59c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
b.php
View File

@@ -1,6 +1,6 @@
<?php
$dir = "static/banners/";
$files = scandir($dir);
$files = scandir($dir, SCANDIR_SORT_NONE);
$images = array_diff($files, array('.', '..'));
$name = $images[array_rand($images)];
// open the file in a binary mode